test(clv2): add coverage for instinct-cli prune, projects ops, promote dry-run, normalize-url

[gaurav0107]

What Changed

Adds pytest coverage to skills/continuous-learning-v2/scripts/test_parse_instinct.py
for functions in instinct-cli.py that previously had zero or insufficient tests.
No production code is modified — this is a test-only change (+245 lines, one file).

New tests, mapped 1:1 to the gaps in the issue:

• _normalize_remote_url — scp-style git@host:org/repo.git, https with embedded
  credentials, file:// local paths, .git/trailing-slash stripping, network-URL
  lowercasing, case-preserving local paths, and idempotence.
• _promote_specific dry-run — asserts dry_run=True returns 0, prints [DRY RUN],
  and writes no file to the global scope (the existing suite only covered the force path).
• projects delete / gc / merge — invalid-id, not-found, --dry-run, and
  --force paths over the registry and on-disk storage, verifying every destructive
  branch is gated and dry-run leaves state untouched.
• cmd_prune — --dry-run keeps files; non-dry-run deletes only entries at/over the
  TTL and preserves fresh ones; --quiet suppresses output.

Why This Change

These functions handle destructive operations (project deletion, GC, merge, prune) and
project-identity hashing (_normalize_remote_url), yet several had no regression tests.
Closing these gaps protects user data paths and documents the intended dry-run/force
semantics.

Testing Done

All run locally with CLAUDE_PLUGIN_ROOT unset (clean env):

• python3 -m pytest skills/continuous-learning-v2/scripts/test_parse_instinct.py →
  90 passed (68 existing + 22 new), 0 failed.
• node tests/run-all.js → 2898 passed, 0 failed (no regression).
• node scripts/ci/validate-no-personal-paths.js → pass.
• node scripts/ci/check-unicode-safety.js → pass.

Tests reuse the existing project_tree / patch_globals fixtures and operate strictly
inside tmp_path; all confirmation prompts are bypassed via force/dry_run, so no test
invokes input().

Type of Change

• Test coverage (no production behavior change)
• Bug fix
• New feature
• Breaking change

Security & Quality Checklist

• No production code modified; additive test-only diff
• Conventional Commits (test(clv2): ...)
• No personal absolute paths (CI validator passes)
• Destructive helpers exercised only inside temp dirs
• No new dependencies

Documentation

No documentation changes required — internal test coverage only.

Fixes #2302

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Tests
  • Added broader test coverage for instinct CLI behavior, including remote URL normalization, project deletion, garbage collection, merging, and pruning.
  • Verified dry-run semantics (no filesystem/registry changes), force actions, missing/invalid project handling, and idempotent URL cleanup.
  • Added checks for quiet mode output suppression and age-based removal of expired items, including the “nothing to do” behavior.

Walkthrough

Adds unit tests in skills/continuous-learning-v2/scripts/test_parse_instinct.py for _normalize_remote_url, _promote_specific dry-run, projects delete/gc/merge, and cmd_prune. No production code is changed.

Changes

instinct-cli test coverage

Layer / File(s)	Summary
_normalize_remote_url and _promote_specific dry-run skills/continuous-learning-v2/scripts/test_parse_instinct.py	Covers empty/None input, scp-style conversion, HTTPS credential/scheme stripping, lowercasing, .git and trailing slash removal, file:// case preservation, idempotency, and _promote_specific dry-run output plus no global file write.
Project delete, gc, and merge tests skills/continuous-learning-v2/scripts/test_parse_instinct.py	Covers delete invalid-id and missing-project errors, dry-run preservation, force deletion, gc no-candidates and zero-value removal, and merge self-merge rejection, missing source, dry-run, and force-mode storage/registry updates.
cmd_prune tests skills/continuous-learning-v2/scripts/test_parse_instinct.py	Adds a _pending_item helper and tests dry-run retention, age-based deletion of expired items, and quiet=True output suppression.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• affaan-m/ECC#2009: Adds tests around the same instinct-cli.py project-scoped behaviors and URL normalization paths.
• affaan-m/ECC#2323: Touches the same project registry and storage maintenance paths exercised by the new delete/gc/merge tests.

Poem

A prune, a merge, a URL made neat,
Dry-runs keep their promises discreet.
Old items fade, new paths align,
And test cases now draw the line.
Quiet clicks where assertions meet.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 3.85% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the test coverage added in this PR.
Description check	✅ Passed	The description matches the test-only changes and the functions covered in the diff.
Linked Issues check	✅ Passed	The new tests cover the requested prune, project ops, _promote_specific dry-run, and URL normalization gaps.
Out of Scope Changes check	✅ Passed	Changes are confined to a single test file and align with the coverage-focused objectives.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gaurav0107]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/continuous-learning-v2/scripts/test_parse_instinct.py`:
- Around line 1202-1210: The dry-run tests only verify registry/output state and
should also assert the filesystem remains unchanged. Update
`test_projects_gc_dry_run_keeps_entry` to confirm `projects_dir/empty1` still
exists after calling `_cmd_projects_gc`, and update
`test_projects_merge_dry_run_no_changes` to confirm nothing was written under
`dest/instincts/personal`. Use the existing `patch_globals`, `tree`, and
`_cmd_projects_gc` / `_cmd_projects_merge` test setup to add these no-op storage
assertions.
- Around line 1321-1330: The quiet-mode prune test only asserts stdout is empty,
so it can miss unexpected stderr output from cmd_prune. Update
test_cmd_prune_quiet_suppresses_output to also verify capsys.readouterr().err is
empty after calling cmd_prune(args), keeping the check aligned with the quiet
behavior implemented by cmd_prune and its quiet handling in
_collect_pending_instincts/prune output paths.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 38f2ccf5-e35b-429c-b30a-f1dff0c1ef9a

📥 Commits

Reviewing files that changed from the base of the PR and between 2bc924f and bafea23.

📒 Files selected for processing (1)

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

📜 Review details

⏰ Context from checks skipped due to timeout. (20)

• GitHub Check: Greptile Review
• GitHub Check: Test (windows-latest, Node 22.x, npm)
• GitHub Check: Test (windows-latest, Node 22.x, yarn)
• GitHub Check: Test (macos-latest, Node 18.x, yarn)
• GitHub Check: Test (windows-latest, Node 20.x, npm)
• GitHub Check: Test (macos-latest, Node 18.x, bun)
• GitHub Check: Test (windows-latest, Node 18.x, yarn)
• GitHub Check: Test (macos-latest, Node 20.x, yarn)
• GitHub Check: Test (windows-latest, Node 22.x, pnpm)
• GitHub Check: Test (windows-latest, Node 20.x, yarn)
• GitHub Check: Test (windows-latest, Node 20.x, pnpm)
• GitHub Check: Test (macos-latest, Node 18.x, pnpm)
• GitHub Check: Test (macos-latest, Node 18.x, npm)
• GitHub Check: Test (windows-latest, Node 18.x, npm)
• GitHub Check: Test (ubuntu-latest, Node 18.x, pnpm)
• GitHub Check: Test (ubuntu-latest, Node 18.x, bun)
• GitHub Check: Test (windows-latest, Node 18.x, pnpm)
• GitHub Check: Test (ubuntu-latest, Node 18.x, yarn)
• GitHub Check: Test (ubuntu-latest, Node 18.x, npm)
• GitHub Check: Coverage

🧰 Additional context used

📓 Path-based instructions (13)

**/*.{js,ts,jsx,tsx,py,java,cs,go,rb,php,scala,kt}

📄 CodeRabbit inference engine (.cursor/rules/common-coding-style.md)

**/*.{js,ts,jsx,tsx,py,java,cs,go,rb,php,scala,kt}: Always create new objects, never mutate existing ones. Use immutable patterns to prevent hidden side effects and enable safe concurrency
Organize code into many small files (200-400 lines typical, 800 lines max) organized by feature/domain rather than by type
Always handle errors explicitly at every level and never silently swallow errors
Always validate all user input before processing at system boundaries
Use schema-based validation where available
Fail fast with clear error messages when validation fails
Never trust external data (API responses, user input, file content)
Ensure code is readable and well-named
Keep functions small (less than 50 lines)
Keep files focused (less than 800 lines)
Avoid deep nesting (more than 4 levels)
Do not use hardcoded values; use constants or configuration instead

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.{js,ts,jsx,tsx,py,java,cs,rb,go,php,swift,kt,rs,c,cpp,h,hpp}

📄 CodeRabbit inference engine (.cursor/rules/common-security.md)

No hardcoded secrets (API keys, passwords, tokens) - validate before any commit

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.{js,ts,jsx,tsx,py,java,cs,rb,go,php}

📄 CodeRabbit inference engine (.cursor/rules/common-security.md)

**/*.{js,ts,jsx,tsx,py,java,cs,rb,go,php}: All user inputs must be validated
Enable CSRF protection on all state-changing endpoints
Verify authentication and authorization for all protected endpoints
Implement rate limiting on all endpoints to prevent abuse
Ensure error messages do not leak sensitive data in responses

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.{js,ts,jsx,tsx,py,java,cs,rb,go,php,sql}

📄 CodeRabbit inference engine (.cursor/rules/common-security.md)

Use parameterized queries to prevent SQL injection

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.{js,ts,jsx,tsx,py,java,cs,rb,go,php,swift,kt,rs,c,cpp,h,hpp,properties,yml,yaml,json,env,config}

📄 CodeRabbit inference engine (.cursor/rules/common-security.md)

NEVER hardcode secrets in source code - ALWAYS use environment variables or a secret manager

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.{py,pyi}

📄 CodeRabbit inference engine (.cursor/rules/python-coding-style.md)

**/*.{py,pyi}: Follow PEP 8 conventions in Python code
Use type annotations on all function signatures in Python
Prefer immutable data structures such as frozen dataclasses and NamedTuple in Python

**/*.{py,pyi}: Auto-format Python files using black/ruff after edit
Run type checking using mypy/pyright after editing Python files

**/*.{py,pyi}: Use Protocol from typing module for duck typing and defining object shapes in Python
Use dataclasses with @dataclass decorator for DTOs (Data Transfer Objects) in Python
Use context managers (with statement) for resource management in Python
Use generators for lazy evaluation and memory-efficient iteration in Python

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.py

📄 CodeRabbit inference engine (.cursor/rules/python-coding-style.md)

**/*.py: Use black for code formatting in Python
Use isort for import sorting in Python
Use ruff for linting Python code

Avoid using print() statements in Python code; use the logging module instead

**/*.py: Retrieve secrets and API keys from environment variables using os.environ with error handling (raise KeyError if missing) rather than hardcoding credentials
Use bandit for static security analysis in Python projects

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*test*.{py,pyi}

📄 CodeRabbit inference engine (.cursor/rules/python-testing.md)

**/*test*.{py,pyi}: Use pytest as the testing framework for Python projects
Use pytest.mark for test categorization with markers like @pytest.mark.unit and @pytest.mark.integration

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.{js,ts,jsx,tsx,py,java,go,rs,kt,cpp,c,fs}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{js,ts,jsx,tsx,py,java,go,rs,kt,cpp,c,fs}: Write tests before implementation using TDD workflow: write failing test (RED), implement minimal code (GREEN), then refactor (IMPROVE)
Keep functions small (<50 lines) and files focused (<800 lines, typical 200-400 lines)
Avoid deep nesting (>4 levels)

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.{js,ts,jsx,tsx,py,java,go,rs,kt}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{js,ts,jsx,tsx,py,java,go,rs,kt}: Never mutate existing objects; always create new objects with changes applied (Immutability requirement)
Handle errors at every level; provide user-friendly messages in UI code and detailed context in server-side logs
Ensure error messages don't leak sensitive data

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

skills/**/*.{js,ts,py,sh}

📄 CodeRabbit inference engine (AGENTS.md)

Place new workflow contributions in skills/ directory as the canonical workflow surface

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

skills/**/scripts/**

⚙️ CodeRabbit configuration file

skills/**/scripts/**: Review generated or imported scripts as untrusted-input tooling. Flag RCE, path traversal, network fetches without validation, and writes outside the expected workspace.

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

{skills,commands,agents,rules}/**

⚙️ CodeRabbit configuration file

{skills,commands,agents,rules}/**: Focus on prompt-injection resilience, tool-permission scope, destructive action guards, and secret exfiltration risks.

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

🧠 Learnings (1)

📚 Learning: 2026-06-27T15:41:48.588Z

Learnt from: gaurav0107
Repo: affaan-m/ECC PR: 2369
File: skills/continuous-learning-v2/scripts/test_parse_instinct.py:1056-1082
Timestamp: 2026-06-27T15:41:48.588Z
Learning: In this repo, the Ruff configuration for Python files under `skills/continuous-learning-v2/scripts/` selects only `E/F/I/N/W/UP`, and `flake8-pytest-style` (e.g., `PT018`) is not enabled. During code review for files in this directory, don’t assume `PT018` will be enforced by CI/ruff; only raise/test for issues that are covered by the enabled Ruff rules (or confirm the relevant rule is enabled before relying on it).

Applied to files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

🪛 ast-grep (0.44.0)

skills/continuous-learning-v2/scripts/test_parse_instinct.py

[info] 1170-1170: use jsonify instead of json.dumps for JSON output
Context: json.dumps({"proj1": {"name": "p1"}})
Note: [CWE-116] Improper Encoding or Escaping of Output.

(use-jsonify)

---

[info] 1182-1182: use jsonify instead of json.dumps for JSON output
Context: json.dumps({"proj1": {"name": "p1"}})
Note: [CWE-116] Improper Encoding or Escaping of Output.

(use-jsonify)

---

[info] 1204-1204: use jsonify instead of json.dumps for JSON output
Context: json.dumps({"empty1": {"name": "e1"}})
Note: [CWE-116] Improper Encoding or Escaping of Output.

(use-jsonify)

---

[info] 1218-1218: use jsonify instead of json.dumps for JSON output
Context: json.dumps({"empty1": {"name": "e1"}, "full1": {"name": "f1"}})
Note: [CWE-116] Improper Encoding or Escaping of Output.

(use-jsonify)

---

[info] 1240-1240: use jsonify instead of json.dumps for JSON output
Context: json.dumps({"dest": {"name": "d"}})
Note: [CWE-116] Improper Encoding or Escaping of Output.

(use-jsonify)

---

[info] 1251-1251: use jsonify instead of json.dumps for JSON output
Context: json.dumps({"src": {"name": "s"}, "dest": {"name": "d"}})
Note: [CWE-116] Improper Encoding or Escaping of Output.

(use-jsonify)

---

[info] 1266-1266: use jsonify instead of json.dumps for JSON output
Context: json.dumps({"src": {"name": "s"}, "dest": {"name": "d"}})
Note: [CWE-116] Improper Encoding or Escaping of Output.

(use-jsonify)

🪛 Ruff (0.15.18)

skills/continuous-learning-v2/scripts/test_parse_instinct.py

[warning] 1156-1156: Unused function argument: patch_globals

(ARG001)

---

[warning] 1162-1162: Unused function argument: patch_globals

(ARG001)

---

[warning] 1213-1213: Unused function argument: capsys

(ARG001)

---

[warning] 1233-1233: Unused function argument: patch_globals

(ARG001)

---

[warning] 1258-1258: Assertion should be broken down into multiple parts

Break down assertion into multiple parts

(PT018)

---

[warning] 1262-1262: Unused function argument: capsys

(ARG001)

---

[warning] 1281-1281: Missing return type annotation for private function _pending_item

(ANN202)

[greptile-apps]

Greptile Summary

Adds 245 lines of new pytest coverage for four previously-uncovered areas in instinct-cli.py: _normalize_remote_url, _promote_specific dry-run, the projects delete/gc/merge commands, and cmd_prune. No production code is touched.

• _normalize_remote_url — seven tests cover scp-style, https-with-credentials, file-scheme, trailing-slash/.git stripping, network lowercasing, and idempotence; all assertions match the production regex pipeline precisely.
• Destructive operations — projects delete, gc, and merge each get invalid-id, not-found, dry-run, and force paths; cmd_prune gets dry-run, selective-expiry, quiet, and empty-list paths; every dry-run assertion is backed by a filesystem check confirming state is untouched.
• Previously-flagged gaps — the symmetric destination-not-found error in _cmd_projects_merge and the empty-pending-list branch in cmd_prune are now covered by test_projects_merge_missing_destination and test_cmd_prune_empty_pending_nothing_to_do respectively.

Confidence Score: 5/5

Test-only change adding 245 lines of regression coverage for destructive operations; no production code modified.

Every new assertion was traced against the production code and confirmed correct — output strings, return codes, filesystem side-effects, and monkeypatching all align. Both gaps flagged in earlier review rounds are now closed. The change is additive and isolated to a single test file.

No files require special attention.

Important Files Changed

Filename	Overview
skills/continuous-learning-v2/scripts/test_parse_instinct.py	+245 lines of test-only coverage for _normalize_remote_url, _promote_specific dry-run, projects delete/gc/merge, and cmd_prune; all assertions verified against production code behavior, monkeypatching applied correctly through the module object, both previously-flagged gaps are now addressed.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[New Test Coverage] --> B[_normalize_remote_url]
    A --> C[_promote_specific dry-run]
    A --> D[projects delete]
    A --> E[projects gc]
    A --> F[projects merge]
    A --> G[cmd_prune]

    B --> B1[empty / None]
    B --> B2[scp-style git@ URL]
    B --> B3[https + credentials]
    B --> B4[network lowercasing]
    B --> B5[.git + trailing slash]
    B --> B6[file:// case preserve]
    B --> B7[idempotence]

    C --> C1[returns 0]
    C --> C2[prints DRY RUN]
    C --> C3[writes no file]

    D --> D1[invalid ID]
    D --> D2[not found]
    D --> D3[dry-run keeps state]
    D --> D4[force removes dir + registry]

    E --> E1[no candidates]
    E --> E2[dry-run keeps state]
    E --> E3[force removes zero-value only]

    F --> F1[same id]
    F --> F2[missing source]
    F --> F3[missing destination]
    F --> F4[dry-run no changes]
    F --> F5[force moves + removes source]

    G --> G1[dry-run keeps files]
    G --> G2[deletes only expired]
    G --> G3[quiet suppresses output]
    G --> G4[empty list no-op]

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[New Test Coverage] --> B[_normalize_remote_url]
    A --> C[_promote_specific dry-run]
    A --> D[projects delete]
    A --> E[projects gc]
    A --> F[projects merge]
    A --> G[cmd_prune]

    B --> B1[empty / None]
    B --> B2[scp-style git@ URL]
    B --> B3[https + credentials]
    B --> B4[network lowercasing]
    B --> B5[.git + trailing slash]
    B --> B6[file:// case preserve]
    B --> B7[idempotence]

    C --> C1[returns 0]
    C --> C2[prints DRY RUN]
    C --> C3[writes no file]

    D --> D1[invalid ID]
    D --> D2[not found]
    D --> D3[dry-run keeps state]
    D --> D4[force removes dir + registry]

    E --> E1[no candidates]
    E --> E2[dry-run keeps state]
    E --> E3[force removes zero-value only]

    F --> F1[same id]
    F --> F2[missing source]
    F --> F3[missing destination]
    F --> F4[dry-run no changes]
    F --> F5[force moves + removes source]

    G --> G1[dry-run keeps files]
    G --> G2[deletes only expired]
    G --> G3[quiet suppresses output]
    G --> G4[empty list no-op]

Loading

_{Reviews (2): Last reviewed commit: "test(clv2): cover merge missing-destinat..." | Re-trigger Greptile}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/continuous-learning-v2/scripts/test_parse_instinct.py`:
- Line 1249: Add `@pytest.mark.unit` to the new test function
test_projects_merge_missing_destination so it matches the rest of the test
suite’s unit-test convention. Update the decorator alongside the existing pytest
test definition in test_parse_instinct.py, keeping the change scoped to that
test and any similarly added tests in the same area if present.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e8dd41a7-6326-42c9-8647-33c3971c0f76

📥 Commits

Reviewing files that changed from the base of the PR and between 890a6dc and 096b61a.

📒 Files selected for processing (1)

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

📜 Review details

⏰ Context from checks skipped due to timeout. (28)

• GitHub Check: Greptile Review
• GitHub Check: Test (ubuntu-latest, Node 22.x, bun)
• GitHub Check: Test (windows-latest, Node 18.x, pnpm)
• GitHub Check: Test (macos-latest, Node 18.x, npm)
• GitHub Check: Test (windows-latest, Node 22.x, pnpm)
• GitHub Check: Test (windows-latest, Node 18.x, yarn)
• GitHub Check: Test (windows-latest, Node 20.x, npm)
• GitHub Check: Test (macos-latest, Node 18.x, bun)
• GitHub Check: Test (windows-latest, Node 20.x, pnpm)
• GitHub Check: Test (ubuntu-latest, Node 22.x, yarn)
• GitHub Check: Test (windows-latest, Node 22.x, npm)
• GitHub Check: Test (windows-latest, Node 20.x, yarn)
• GitHub Check: Test (macos-latest, Node 22.x, pnpm)
• GitHub Check: Test (ubuntu-latest, Node 22.x, pnpm)
• GitHub Check: Test (ubuntu-latest, Node 22.x, npm)
• GitHub Check: Test (macos-latest, Node 22.x, bun)
• GitHub Check: Test (ubuntu-latest, Node 18.x, npm)
• GitHub Check: Test (macos-latest, Node 20.x, bun)
• GitHub Check: Test (ubuntu-latest, Node 20.x, yarn)
• GitHub Check: Test (windows-latest, Node 22.x, yarn)
• GitHub Check: Test (ubuntu-latest, Node 20.x, bun)
• GitHub Check: Test (ubuntu-latest, Node 20.x, npm)
• GitHub Check: Test (windows-latest, Node 18.x, npm)
• GitHub Check: Test (ubuntu-latest, Node 18.x, yarn)
• GitHub Check: Test (ubuntu-latest, Node 18.x, bun)
• GitHub Check: Test (ubuntu-latest, Node 18.x, pnpm)
• GitHub Check: Test (ubuntu-latest, Node 20.x, pnpm)
• GitHub Check: Coverage

🧰 Additional context used

📓 Path-based instructions (13)

**/*.{js,ts,jsx,tsx,py,java,cs,go,rb,php,scala,kt}

📄 CodeRabbit inference engine (.cursor/rules/common-coding-style.md)

**/*.{js,ts,jsx,tsx,py,java,cs,go,rb,php,scala,kt}: Always create new objects, never mutate existing ones. Use immutable patterns to prevent hidden side effects and enable safe concurrency
Organize code into many small files (200-400 lines typical, 800 lines max) organized by feature/domain rather than by type
Always handle errors explicitly at every level and never silently swallow errors
Always validate all user input before processing at system boundaries
Use schema-based validation where available
Fail fast with clear error messages when validation fails
Never trust external data (API responses, user input, file content)
Ensure code is readable and well-named
Keep functions small (less than 50 lines)
Keep files focused (less than 800 lines)
Avoid deep nesting (more than 4 levels)
Do not use hardcoded values; use constants or configuration instead

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.{js,ts,jsx,tsx,py,java,cs,rb,go,php,swift,kt,rs,c,cpp,h,hpp}

📄 CodeRabbit inference engine (.cursor/rules/common-security.md)

No hardcoded secrets (API keys, passwords, tokens) - validate before any commit

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.{js,ts,jsx,tsx,py,java,cs,rb,go,php}

📄 CodeRabbit inference engine (.cursor/rules/common-security.md)

**/*.{js,ts,jsx,tsx,py,java,cs,rb,go,php}: All user inputs must be validated
Enable CSRF protection on all state-changing endpoints
Verify authentication and authorization for all protected endpoints
Implement rate limiting on all endpoints to prevent abuse
Ensure error messages do not leak sensitive data in responses

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.{js,ts,jsx,tsx,py,java,cs,rb,go,php,sql}

📄 CodeRabbit inference engine (.cursor/rules/common-security.md)

Use parameterized queries to prevent SQL injection

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.{js,ts,jsx,tsx,py,java,cs,rb,go,php,swift,kt,rs,c,cpp,h,hpp,properties,yml,yaml,json,env,config}

📄 CodeRabbit inference engine (.cursor/rules/common-security.md)

NEVER hardcode secrets in source code - ALWAYS use environment variables or a secret manager

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.{py,pyi}

📄 CodeRabbit inference engine (.cursor/rules/python-coding-style.md)

**/*.{py,pyi}: Follow PEP 8 conventions in Python code
Use type annotations on all function signatures in Python
Prefer immutable data structures such as frozen dataclasses and NamedTuple in Python

**/*.{py,pyi}: Auto-format Python files using black/ruff after edit
Run type checking using mypy/pyright after editing Python files

**/*.{py,pyi}: Use Protocol from typing module for duck typing and defining object shapes in Python
Use dataclasses with @dataclass decorator for DTOs (Data Transfer Objects) in Python
Use context managers (with statement) for resource management in Python
Use generators for lazy evaluation and memory-efficient iteration in Python

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.py

📄 CodeRabbit inference engine (.cursor/rules/python-coding-style.md)

**/*.py: Use black for code formatting in Python
Use isort for import sorting in Python
Use ruff for linting Python code

Avoid using print() statements in Python code; use the logging module instead

**/*.py: Retrieve secrets and API keys from environment variables using os.environ with error handling (raise KeyError if missing) rather than hardcoding credentials
Use bandit for static security analysis in Python projects

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*test*.{py,pyi}

📄 CodeRabbit inference engine (.cursor/rules/python-testing.md)

**/*test*.{py,pyi}: Use pytest as the testing framework for Python projects
Use pytest.mark for test categorization with markers like @pytest.mark.unit and @pytest.mark.integration

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.{js,ts,jsx,tsx,py,java,go,rs,kt,cpp,c,fs}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{js,ts,jsx,tsx,py,java,go,rs,kt,cpp,c,fs}: Write tests before implementation using TDD workflow: write failing test (RED), implement minimal code (GREEN), then refactor (IMPROVE)
Keep functions small (<50 lines) and files focused (<800 lines, typical 200-400 lines)
Avoid deep nesting (>4 levels)

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

**/*.{js,ts,jsx,tsx,py,java,go,rs,kt}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{js,ts,jsx,tsx,py,java,go,rs,kt}: Never mutate existing objects; always create new objects with changes applied (Immutability requirement)
Handle errors at every level; provide user-friendly messages in UI code and detailed context in server-side logs
Ensure error messages don't leak sensitive data

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

skills/**/*.{js,ts,py,sh}

📄 CodeRabbit inference engine (AGENTS.md)

Place new workflow contributions in skills/ directory as the canonical workflow surface

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

skills/**/scripts/**

⚙️ CodeRabbit configuration file

skills/**/scripts/**: Review generated or imported scripts as untrusted-input tooling. Flag RCE, path traversal, network fetches without validation, and writes outside the expected workspace.

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

{skills,commands,agents,rules}/**

⚙️ CodeRabbit configuration file

{skills,commands,agents,rules}/**: Focus on prompt-injection resilience, tool-permission scope, destructive action guards, and secret exfiltration risks.

Files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

🧠 Learnings (1)

📚 Learning: 2026-06-27T15:41:48.588Z

Learnt from: gaurav0107
Repo: affaan-m/ECC PR: 2369
File: skills/continuous-learning-v2/scripts/test_parse_instinct.py:1056-1082
Timestamp: 2026-06-27T15:41:48.588Z
Learning: In this repo, the Ruff configuration for Python files under `skills/continuous-learning-v2/scripts/` selects only `E/F/I/N/W/UP`, and `flake8-pytest-style` (e.g., `PT018`) is not enabled. During code review for files in this directory, don’t assume `PT018` will be enforced by CI/ruff; only raise/test for issues that are covered by the enabled Ruff rules (or confirm the relevant rule is enabled before relying on it).

Applied to files:

• skills/continuous-learning-v2/scripts/test_parse_instinct.py

🪛 ast-grep (0.44.0)

skills/continuous-learning-v2/scripts/test_parse_instinct.py

[info] 1251-1251: use jsonify instead of json.dumps for JSON output
Context: json.dumps({"src": {"name": "s"}})
Note: [CWE-116] Improper Encoding or Escaping of Output.

(use-jsonify)

🪛 Ruff (0.15.18)

skills/continuous-learning-v2/scripts/test_parse_instinct.py

[warning] 1351-1351: Prefer list over useless lambda

Replace with lambda with list

(PIE807)

🔇 Additional comments (1)

skills/continuous-learning-v2/scripts/test_parse_instinct.py (1)

1250-1255: LGTM!

Also applies to: 1351-1357