[Refactor]: Deduplicate SimpleDirectoryReader.load_file and aload_file

[enjoyandlove]

Documentation Issue Description

Summary

SimpleDirectoryReader.load_file and SimpleDirectoryReader.aload_file in llama-index-core/llama_index/core/readers/file/base.py repeat the same branching flow (file readers vs raw read, metadata, filename_as_id, error handling). Both call sites include # TODO: make this less redundant (around lines 590 and 660). Consolidate the shared logic so fixes stay in one place and sync/async paths do not drift.

Motivation

Duplicated code tends to get updated in only one path.
Today, sync vs async error handling differs: load_file wraps failures as Exception("Error loading file") from the original exception; aload_file re-raises the original. The refactor should preserve each public entry point’s behavior unless the PR explicitly documents a deliberate alignment and adds tests.

Expected outcome

Less bug surface in file loading.
Simpler reviews and clearer tests for directory/file reading.

Scope (per CONTRIBUTING.md)

Package: llama-index-core only.
Out of scope: new integration packages or unrelated refactors.

Suggested approach

Extract shared logic into private helper(s), parameterized by how content is loaded (load_data vs aload_data).
Keep public method signatures and default behavior stable.

How to validate (from CONTRIBUTING quick start)

Repo root: uv sync (and uv run pre-commit install if you use hooks).
Package dir: cd llama-index-core
Tests: uv run -- pytest
If you change style-sensitive code: from repo root, uv run make lint (and format as you normally do for this repo, e.g. uv run make format if that is your workflow).

Acceptance criteria

load_file and aload_file share one implementation of branching / metadata / ID logic.
Behavior matches pre-refactor unless the PR states otherwise and includes tests for any change.
uv run -- pytest passes in llama-index-core.
uv run make lint passes from repo root when applicable.

References

llama-index-core/llama_index/core/readers/file/base.py — load_file, aload_file
Optional one-liner for the issue list: “Deduplicate SimpleDirectoryReader sync/async file loading; keep behavior; tests + lint per CONTRIBUTING.”
Is this issue right ?or not?

[PrajwaL-N-TECHIE]

Hi, I'd like to work on this refactor! I'll audit both load_file and aload_file to extract the shared logic into a common private method, keeping the sync/async split clean. Will make sure existing tests still pass and add coverage for any gaps.

[dosubot]

Hi, @enjoyandlove. I'm Dosu, and I'm helping the LlamaIndex team manage their backlog and am marking this issue as stale.

Issue Summary

• You opened a refactor request to remove duplicated logic between SimpleDirectoryReader.load_file and aload_file.
• The goal is to preserve the existing sync/async behavior difference while extracting shared code into a private helper.
• The issue is scoped to llama-index-core and includes clear validation and acceptance criteria.
• In the comments, @PrajwaL-N-TECHIE volunteered to implement the change and verify it with existing and any added tests.

Next Steps

• Please let us know if this issue is still relevant on the latest version of LlamaIndex; if so, you can keep the discussion open by commenting here.
• Otherwise, this issue will be automatically closed in 7 days.

Thanks for your understanding and contribution!